Skip to content

agentgateway: better defaults in deployment #12529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

agentgateway: better defaults in deployment #12529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/kgateway/helm/kgateway/templates/gateway/agent-gateway-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ spec:
template:
metadata:
annotations:
prometheus.io/path: /metrics
prometheus.io/port: "15020"
prometheus.io/scrape: "true"
{{- with $gateway.extraPodAnnotations }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions pkg/deployer/gateway_parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ func GetInMemoryGatewayParameters(name string, imageInfo *ImageInfo, gatewayClas
// set for the agentgateway deployment.
func defaultAgentgatewayParameters(imageInfo *ImageInfo, omitDefaultSecurityContext bool) *v1alpha1.GatewayParameters {
gwp := defaultGatewayParameters(imageInfo, omitDefaultSecurityContext)
// Leave unset to allow HPA, etc
gwp.Spec.Kube.Deployment.Replicas = nil
gwp.Spec.Kube.Agentgateway.Enabled = ptr.To(true)
gwp.Spec.Kube.PodTemplate.ReadinessProbe.HTTPGet.Path = "/healthz/ready"
gwp.Spec.Kube.PodTemplate.ReadinessProbe.HTTPGet.Port = intstr.FromInt(15021)
Expand Down
4 changes: 3 additions & 1 deletion test/deployer/testdata/agentgateway-omitdefaultsecuritycontext-out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ metadata:
gateway.networking.k8s.io/gateway-class-name: agentgateway
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: gw
Expand All @@ -83,6 +82,9 @@ spec:
template:
metadata:
annotations:
prometheus.io/path: /metrics
prometheus.io/port: "15020"
prometheus.io/scrape: "true"
labels:
app.kubernetes.io/name: gw
app.kubernetes.io/instance: gw
Expand Down
4 changes: 3 additions & 1 deletion test/deployer/testdata/agentgateway-omitdefaultsecuritycontext-ref-gwp-on-gw-out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ metadata:
gateway.networking.k8s.io/gateway-class-name: agentgateway
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: gw
Expand All @@ -83,6 +82,9 @@ spec:
template:
metadata:
annotations:
prometheus.io/path: /metrics
prometheus.io/port: "15020"
prometheus.io/scrape: "true"
labels:
app.kubernetes.io/name: gw
app.kubernetes.io/instance: gw
Expand Down
4 changes: 3 additions & 1 deletion test/deployer/testdata/agentgateway-out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ metadata:
gateway.networking.k8s.io/gateway-class-name: agentgateway
app.kubernetes.io/managed-by: Helm
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/name: gw
Expand All @@ -83,6 +82,9 @@ spec:
template:
metadata:
annotations:
prometheus.io/path: /metrics
prometheus.io/port: "15020"
prometheus.io/scrape: "true"
labels:
app.kubernetes.io/name: gw
app.kubernetes.io/instance: gw
Expand Down