e2e: Extend route replacement policy tests #12291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to the kgateway-dev#12199 PR, which updated the route translator to handle invalid policy attached listener-and-gateway-wide. This commit introduces several new functional tests to validate the new behavior and compliment existing route-level coverage in the route replacement e2e suite. Partially fixes kgateway-dev#11937. Signed-off-by: timflannagan <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR extends the route replacement policy tests by adding new end-to-end test cases to validate the behavior when invalid TrafficPolicies are attached at gateway-wide and listener-specific levels. The changes complement existing route-level coverage in the route replacement e2e test suite.
Key changes:
- Addition of three new test scenarios for invalid policy attachment
- Creation of YAML manifests for testing gateway-wide and listener-specific policy isolation
- Implementation of test functions to verify blast radius containment and route replacement behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/kubernetes/e2e/features/routereplacement/types.go | Added new manifest paths and proxy object metadata definitions for the extended test scenarios |
| test/kubernetes/e2e/features/routereplacement/testdata/listener-specific-invalid-policy.yaml | Test manifest for listener-specific invalid policy isolation testing |
| test/kubernetes/e2e/features/routereplacement/testdata/listener-merge-blast-radius.yaml | Test manifest for testing blast radius when merged listeners have invalid policies |
| test/kubernetes/e2e/features/routereplacement/testdata/gateway-wide-invalid-policy.yaml | Test manifest for gateway-wide invalid policy testing |
| test/kubernetes/e2e/features/routereplacement/suite.go | Implementation of three new test functions to validate policy attachment behavior and route replacement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
bot
added
kind/cleanup
puertomontt
approved these changes
Sep 16, 2025
jenshu
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to the #12199 PR, which updated the route translator to handle invalid policy attached listener-and-gateway-wide.
This commit introduces several new functional tests to validate the new behavior and compliment existing route-level coverage in the route replacement e2e suite.
Partially fixes #11937.
Change Type
/kind cleanup
Changelog
Additional Notes