-
Notifications
You must be signed in to change notification settings - Fork 585
Inference: Replaces InferencePool v1alpha2 with v1 #11965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/kubernetes/e2e/features/inferenceextension/testdata/epp.yaml
Outdated
Show resolved
Hide resolved
a6c7f5a
to
d59fe28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just ping me once CI is green.
/hold until kubernetes-sigs/gateway-api-inference-extension#1336 is resolved (may pause v1 InferencePool). |
"sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
"sigs.k8s.io/controller-runtime/pkg/source" | ||
infextv1a2 "sigs.k8s.io/gateway-api-inference-extension/api/v1alpha2" | ||
inf "sigs.k8s.io/gateway-api-inference-extension/api/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: infextv1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenshu thanks for the review. @howardjohn convinced me not to include the API version for the alias.
CI failure
|
Signed-off-by: Daneyon Hansen <[email protected]>
Description
Replaces InferencePool v1alpha2 with v1. Since upstream has not published a v1.0.0 release, this PR works off of upstream commit
2d7613c9b2bebada4c212495326272137c5846db
(tracked by #11964).Partially Fixes #11837
Change Type
Changelog
Additional Notes
Kgateway (both agentgateway and envoy dataplanes) is not supporting a v1alph2 -> v1 migration. Other Inference Extension gateways are doing the same.