Skip to content

Conversation

danehans
Copy link
Contributor

Description

Replaces InferencePool v1alpha2 with v1. Since upstream has not published a v1.0.0 release, this PR works off of upstream commit 2d7613c9b2bebada4c212495326272137c5846db (tracked by #11964).

Partially Fixes #11837

Change Type

/kind breaking_change
/kind new_feature

Changelog

Inference: Replaces InferencePool v1alpha2 with v1

Additional Notes

Kgateway (both agentgateway and envoy dataplanes) is not supporting a v1alph2 -> v1 migration. Other Inference Extension gateways are doing the same.

@github-actions github-actions bot added kind/breaking_change kind/feature Categorizes issue or PR as related to a new feature. release-note labels Aug 11, 2025
@danehans danehans force-pushed the issue_11837 branch 2 times, most recently from a6c7f5a to d59fe28 Compare August 11, 2025 20:07
Copy link
Member

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just ping me once CI is green.

@danehans
Copy link
Contributor Author

danehans commented Aug 11, 2025

/hold until kubernetes-sigs/gateway-api-inference-extension#1336 is resolved (may pause v1 InferencePool).

@danehans danehans marked this pull request as draft August 11, 2025 23:18
@danehans danehans marked this pull request as ready for review August 26, 2025 18:54
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
infextv1a2 "sigs.k8s.io/gateway-api-inference-extension/api/v1alpha2"
inf "sigs.k8s.io/gateway-api-inference-extension/api/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: infextv1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenshu thanks for the review. @howardjohn convinced me not to include the API version for the alias.

@jenshu jenshu added this pull request to the merge queue Aug 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@jenshu
Copy link
Contributor

jenshu commented Aug 27, 2025

CI failure

+ make kind-build-and-load
GO111MODULE=on CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -ldflags='-X 'github.com/kgateway-dev/kgateway/v2/internal/version.Version=1.0.0-ci1'' -gcflags='' -o /home/runner/work/kgateway/kgateway/_output/internal/kgateway/kgateway-linux-amd64 ./cmd/kgateway/...
# github.com/kgateway-dev/kgateway/v2/internal/kgateway/agentgatewaysyncer
Error: internal/kgateway/agentgatewaysyncer/service.go:135:21: invalid argument: s.Spec.Selector (variable of struct type "sigs.k8s.io/gateway-api-inference-extension/api/v1".LabelSelector) for built-in len
make: *** [Makefile:352: /home/runner/work/kgateway/kgateway/_output/internal/kgateway/kgateway-linux-amd64] Error 1

@danehans
Copy link
Contributor Author

@jenshu thanks for the review. #12105 caused the CI failure. I'll push an update shortly.

@danehans danehans added this pull request to the merge queue Aug 27, 2025
Merged via the queue into kgateway-dev:main with commit 468d351 Aug 27, 2025
25 checks passed
@danehans danehans deleted the issue_11837 branch August 27, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking_change kind/feature Categorizes issue or PR as related to a new feature. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inference: Add v1 InferencePool Support
4 participants