Skip to content

Commit 252fa09

Browse files
committed
remove use of systemnamespace since we no longer need it
Signed-off-by: Joe McGuire <[email protected]>
1 parent b566384 commit 252fa09

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

internal/kgateway/agentgatewaysyncer/nack/publisher.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,15 @@ var log = logging.New("nack/publisher")
1717

1818
// Publisher converts NACK events from the agentgateway xDS server into Kubernetes Events.
1919
type Publisher struct {
20-
ctx context.Context
21-
client kube.Client
22-
systemNamespace string
20+
ctx context.Context
21+
client kube.Client
2322
}
2423

2524
// NewPublisher creates a new NACK event publisher that will publish k8s events
26-
func NewPublisher(ctx context.Context, client kube.Client, systemNamespace string) *Publisher {
25+
func NewPublisher(ctx context.Context, client kube.Client) *Publisher {
2726
return &Publisher{
28-
client: client,
29-
ctx: ctx,
30-
systemNamespace: systemNamespace,
27+
client: client,
28+
ctx: ctx,
3129
}
3230
}
3331

internal/kgateway/agentgatewaysyncer/syncer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func NewAgwSyncer(
8484
client: client,
8585
statusCollections: &status.StatusCollections{},
8686
//todo, we definitely shouldn't need to use the background context here
87-
NackHandler: nack.NewNackHandler(nack.NewPublisher(context.Background(), client, agwCollections.SystemNamespace)),
87+
NackHandler: nack.NewNackHandler(nack.NewPublisher(context.Background(), client)),
8888
}
8989
}
9090

0 commit comments

Comments
 (0)