Skip to content

Commit b566384

Browse files
committed
lints
Signed-off-by: Joe McGuire <[email protected]>
1 parent 2ce09bd commit b566384

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

internal/kgateway/agentgatewaysyncer/nack/handler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ func (h *NackHandler) HandleAck(ackEvent *AckEvent) {
5757
// FilterEventsAndConvertToNackStatusUpdate filters Kubernetes Events to only process NACK/ACK events for Gateways.
5858
// Returns nil for events that should be ignored, or a NackStatusUpdate for events relevant events.
5959
func (h *NackHandler) FilterEventsAndUpdateState(event *corev1.Event) error {
60-
nackHandlerLog.Debug("Processing event", "reason", event.Reason, "kind", event.InvolvedObject.Kind, "name", event.InvolvedObject.Name, "namespace", event.InvolvedObject.Namespace)
60+
nackHandlerLog.Debug("processing event", "reason", event.Reason, "kind", event.InvolvedObject.Kind, "name", event.InvolvedObject.Name, "namespace", event.InvolvedObject.Namespace)
6161

6262
if event.Reason != ReasonNack && event.Reason != ReasonAck {
63-
nackHandlerLog.Debug("Ignoring event - not a NACK/ACK event", "reason", event.Reason)
63+
nackHandlerLog.Debug("ignoring event - not a NACK/ACK event", "reason", event.Reason)
6464
return nil
6565
}
6666

internal/kgateway/agentgatewaysyncer/nack/publisher.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ func NewPublisher(ctx context.Context, client kube.Client, systemNamespace strin
3333

3434
// onNack publishes a NACK event as a k8s event.
3535
func (p *Publisher) onNack(event NackEvent) {
36-
3736
nackID := ComputeNackID(event.Gateway.Namespace+"/"+event.Gateway.Name, event.TypeUrl)
3837

3938
k8sEvent := &corev1.Event{
@@ -64,11 +63,11 @@ func (p *Publisher) onNack(event NackEvent) {
6463
p.ctx, k8sEvent, metav1.CreateOptions{},
6564
)
6665
if err != nil && !errors.IsAlreadyExists(err) {
67-
log.Error("Failed to publish NACK event for Gateway", "gateway", event.Gateway, "error", err)
66+
log.Error("failed to publish NACK event for Gateway", "gateway", event.Gateway, "error", err)
6867
return
6968
}
7069

71-
log.Debug("Published NACK event for Gateway", "gateway", event.Gateway, "nackID", nackID, "typeURL", event.TypeUrl)
70+
log.Debug("published NACK event for Gateway", "gateway", event.Gateway, "nackID", nackID, "typeURL", event.TypeUrl)
7271
}
7372

7473
// onAck publishes an ACK event as a k8s event.
@@ -104,9 +103,9 @@ func (p *Publisher) onAck(event AckEvent) {
104103
p.ctx, k8sEvent, metav1.CreateOptions{},
105104
)
106105
if err != nil && !errors.IsAlreadyExists(err) {
107-
log.Error("Failed to publish ACK event for Gateway", "gateway", event.Gateway, "error", err)
106+
log.Error("failed to publish ACK event for Gateway", "gateway", event.Gateway, "error", err)
108107
return
109108
}
110109

111-
log.Debug("Published ACK event for Gateway", "gateway", event.Gateway, "typeURL", event.TypeUrl)
110+
log.Debug("published ACK event for Gateway", "gateway", event.Gateway, "typeURL", event.TypeUrl)
112111
}

pkg/agentgateway/plugins/collection.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ func registerGatewayAPITypes() {
211211
return c.GatewayAPI().GatewayV1alpha2().TLSRoutes(namespace)
212212
},
213213
)
214-
215214
}
216215

217216
func registerAdditionalCoreTypes() {

0 commit comments

Comments
 (0)