[ladino] Initial submission of Ladino keyboard

[julian-vargo]

A Rashi font, qwerty-style keyboard of Hebrew characters (alt for roman characters). Optimized for those already familiar with typing in English, Spanish, or Turkish keyboards.

[keyman-server]

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

[LornaSIL]

Thanks for your submission! I haven't checked your keyboard carefully, but I have a few quick suggestions.

• We VERY strongly recommend you use RALT and not just ALT. That way the keystrokes won't interfere with applications that use the ALT for shortcuts. Users will have much fewer issues if you do that.
• We prefer that only LICENSE.md contain the copyright YEAR. That way it doesn't have to be updated, just the LICENSE.md. You have a year in the ladino.kmn, ladino.kps, readme.htm, welcome.htm, and welcome.php (which you will be renaming)
• We generally prefer that the font (and license) would go in the release\shared\fonts folder. That way it can be shared by other projects and also the font gets deployed to be used in our online help system. So, in this case I'd like it put in \release\shared\fonts\hebr\NotoRashiHebrew. If you don't have the full repo cloned, you can create the folder structure to match what I've described so it will go in the correct location.
• That means you'll have to change the path in your .kps to where the file(s) can be found.
  • The description in the .kps file is what will appear on the online keyboard landing page. I recommend you include the description you have in README.md as that is quite good.
• In the help folder the welcome.php should be renamed ladino.php. The header should be:

<?php 
  $pagename = 'Ladino Keyboard Help';
  $pagetitle = $pagename;
  require_once('header.php');
?>

Down below, instead of including graphics, our online system can autogenerate them, so you could include these lines instead of the graphics:

<h2>Desktop Keyboard Layout</h2>
<div id='osk' data-states='default shift rightalt rightalt-shift'>
</div>

Once you submit changes then I can check the workings of the keyboard.

[LornaSIL]

@julian-vargo are you able to make the changes mentioned above?

[julian-vargo]

I'll be able to make the aforementioned changes some time this week! Thank you for all of your help.

[LornaSIL]

@julian-vargo this recent comment was made by someone who is not part of the Keyman team. Please ignore.

[julian-vargo]

I believe I've fixed all of the changes that you suggested. Thank you so much for your patience!

[LornaSIL]

Thank you for updating with those changes. I do see quite a few things that need changing. Please don't be discouraged as it takes awhile to understand the structure of all the files.

In general we don't recommend mixing scripts in a keyboard. This one in particular seems confusing since the main layers are for the Hebrew script which is right to left and then the alt layers are for Latin script. I would highly recommend not including the Latin script. People can, and should, just switch to another keyboard when they want to type Latin script. But anyway, here's the other feedback.

• There is a ladino/welcome folder which should be deleted, including all contents. If that file and contents are more up-to-date, then copy them into the source/welcome folder. Make sure to delete that folder within the ladino root.
• In README.md you don't need the backslash before the underscore https://keyman.com/keyboards/teklado\_ladino
• Delete LICENSE.htm in the source folder as it is unnecessary as the one in the root of ladino is the correct file in our system.
• Delete the help/welcome.php file
• Open the help/ladino.php file and remove the contents and paste the text at the bottom of this comment into that file.
• I think you should delete all of the LALT rules in the .kmn file. They appear to be a duplicate of the RALT rules. The whole reason for separating them is so that LALT will be able to be used by applications for their normal behavior.
  • Once you revise the rules in the .kmn, you should go to the "On-screen" tab and select "Fill from Layout" so it refreshing the on-screen keyboard.
• The touch layout:
  • The shift key on all 4 layers has "Next Layer:" set to "none". On the default layer, that should be set to "Shift", on the shift layer, that should be set to "default". I'm not sure what you would want to happen on the alt layers since this is primarily a hebrew keyboard and not a latin keyboard.
  • Also, the "alt" layer doesn't work because you are now using RALT. So, go to the "alt" layer and click "Edit..." and then rename it to rightalt. Do the same for "shift-alt" but it should be named "rightalt-shift"

• You can always test the keyboard by going to the Build tab, click on "Compile keyboard", then click on "Test keyboard on Web". Select one of the web addresses and click on "Open in Browser". Once you get to the browser, choose you Keyboard and you can test the desktop version. Then click on Device and you can test your tablet layout. You will immediately be able to test whether you can access the different layers.
• Now we switch to the .kps file.
  • Since you updated the welcome folder with some images, you should add those images to the list of files. Otherwise the welcome.htm file cannot display them.
  • Remove LICENSE.htm from your list of files and add LICENSE.md to the list of files.
  • In the Keyboards tab, the code for Ladino can just be lad. There is no need for -001
    • FYI lad means Ladino language with Hebrew script. This is another reason I don't like mixing Latin into this keyboard.
  • Down below, in "Examples" the tag should again be lad and not Ladino.
  • On the Details tab, change the LICENSE.htm to LICENSE.md
  • The version number should be deleted, and select "Package version follows keyboard version". That way the version is always whatever is in the .kmn file. Setting a keyboard version here would only be used in unusual circumstances.
  • Lastly, in the description, you can remove the first two lines

# Teklado Ladino keyboard

## Description

The contents of that description will go on the home page for the keyboard. The title is automatically generated. It will show up like this one:

Here is what I think needs to go in the ladino.php file which I mentioned at the beginning:

<?php
  $pagename = 'Ladino Keyboard Help';
  $pagetitle = $pagename;
  require_once('header.php');
?>

<h2>Keyboard Layout</h2>

<p>
    Basic layout
</p>

<p>
    Konfigurasyon basika
</p>
<img src="basic.png">


<p>
    Shift
</p>
<img src="shift.png">

<p>
    Alt
</p>
<img src="alt.png">

<p>
    Alt+Shift
</p>
<img src="alt_shift.png">

[mcdurdin]

@julian-vargo, please ignore the abusive messages from "jalix75916". We've blocked and reported the user.

[julian-vargo]

Hi, for the php file, I thought I was supposed to do away with the png's, as you mentioned in the very first comment on this thread. Would this work for the php, with the div id='osk' data-states='default':

Keyboard Layout

Basic layout

Konfigurasyon basika

[LornaSIL]

Yes, the .php file can use this instead of the graphics:

<h2>Desktop Keyboard Layout</h2>
<div id='osk' data-states='default shift rightalt rightalt-shift'>
</div>

[LornaSIL]

This PR is getting a bit stale. Would you like me to make the required changes?