Skip to content

Show social proofs in search results #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s4y merged 4 commits into from
Nov 3, 2015
Merged

Show social proofs in search results #1234

s4y merged 4 commits into from
Nov 3, 2015

Conversation

@s4y
Copy link
Contributor

@s4y s4y commented Oct 27, 2015

MarcoPolo
MarcoPolo reviewed Oct 28, 2015
View reviewed changes
react-native/react/search/index.js Outdated
Copy link
Contributor

@MarcoPolo MarcoPolo Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner like this?

proof === matchingProof 
&& (
 <Text>
  ...
 </Text>
)

@MarcoPolo
Copy link
Contributor

MarcoPolo commented Oct 28, 2015

LG%C

chrisnojima
chrisnojima reviewed Oct 28, 2015
View reviewed changes
react-native/ios/Keybase/Images.xcassets/btc.imageset/Contents.json Outdated
Copy link
Contributor

@chrisnojima chrisnojima Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I know I told you to do this but just FYI to all @keybase/react-hackers there changing how assets work in the next version: facebook/react-native#3545

Copy link
Contributor

@MarcoPolo MarcoPolo Oct 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@chrisnojima
Copy link
Contributor

chrisnojima commented Oct 28, 2015

👍 % comments

@s4y s4y force-pushed the sidney/MOBILE-133 branch from 44564be to 58ea292 Compare October 28, 2015 21:09
@s4y
Copy link
Contributor Author

s4y commented Oct 28, 2015

Would someone with Android verify that this works? I can't get the app running in the emulator at the moment.

@cjb
Copy link
Contributor

cjb commented Oct 28, 2015

I wonder if the Appveyor thing would help

@cjb
Copy link
Contributor

cjb commented Oct 29, 2015

(oh, Appveyor is the Windows build.. I was thinking of the one that lets you run the Android app remotely.)

@chrisnojima
Copy link
Contributor

chrisnojima commented Oct 29, 2015

Appetizer I think

On Wednesday, October 28, 2015, Chris Ball [email protected] wrote:

(oh, Appveyor is the Windows build.. I was thinking of the one that lets
you run the Android app remotely.)

—
Reply to this email directly or view it on GitHub
#1234 (comment).

@s4y s4y mentioned this pull request Oct 29, 2015
Merged
@s4y
Copy link
Contributor Author

s4y commented Nov 3, 2015

I haven't heard anything back in a few days, so I'm mergin'.

s4y added a commit that referenced this pull request Nov 3, 2015
@s4y
Merge pull request #1234 from keybase/sidney/MOBILE-133
1dd76a1 
Show social proofs in search results
@s4y s4y merged commit 1dd76a1 into master Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@s4y @MarcoPolo @chrisnojima @cjb