Windows: include hub devices in list like other platforms #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this seems to work, so no reason to exclude them. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I note there is mention of this in the docs but is it intended or just the nature of only using
GUID_DEVINTERFACE_USB_DEVICE? Since importingGUID_DEVINTERFACE_USB_HUBfor thelist_buses, I realise that non-root hubs can be obtained with this too in thelist_devices().I believe it makes since to add it so hubs are included in the device list. If only because it makes Windows listing the same as the other platforms. I also think it makes sense as hub are devices and descriptors can be read, control messages used etc. unlike root hubs.