20250723 mirror and lei fixes #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll be extending the configuration documentaiton so move it to its own file. Signed-off-by: Luis Chamberlain <[email protected]>
We always clone a full repository. This is counter productive and wasteful. Allow users to specify that they are using kpd to help test patches for a git tree which we should expect a mirror on a target mirror path. We simply check for a mirror for you git tree and if present we use it. So for example, all kdevops enterprise deployments can easily profit from this as kdevops has support to mirror all target git trees it supports under /mirror/ through an NFS export for clients. And so small thing guests can be used for kpd instances, which can leverage this NFS export. This allows kpd to be run on smaller guests with less storage needs. This should allow more than one kpd instance to run on small guests too. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
Give Claude Code some guidance on our expecations. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
I've asked Claude Code to just extend the documentation as best as possible. Here as some updates. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
Add a new command-line option that allows users to run KPD in dry-run mode to list candidate patches without processing them. This is useful for debugging issues with patch detection and understanding what patches KPD would process. The dry-run mode: - Fetches relevant subjects from Patchwork using the same logic as normal operation - Lists all candidate patches with their series information - Exits without creating PRs or making any changes - Provides clear output showing patch subjects, series IDs, and metadata This helps diagnose issues like patches being outside the lookback window or problems with the Patchwork API integration. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
Fix a critical bug in patch filtering where project ID comparison was failing due to type mismatch. The configuration file specifies project IDs as strings (e.g., "423"), but the Patchwork API returns them as integers (e.g., 423). This caused the comparison in _is_patch_matching() to fail, resulting in no patches being detected as matching. This bug was preventing KPD from detecting candidate patches in lei-based patchwork instances, including the Linux firmware loader project. The fix converts the expected_value to int before comparison for properties in PATCH_FILTERING_PROPERTIES (project, delegate). Tested with the firmware loader project - now successfully detects patches including "firmware_loader: prevent integer overflow in firmware_loading_timeout()". Since lei-based patchwork instances now work, updates docs to declare it as supported. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
To help developers embrace claude code give examples and gradings of what Claude Code did. We can update with commit IDS and URLs later. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
|
Ugh, the lint changes are minor, any chance you can take care of them? |
|
I'll fix these minor nits. I think its just black. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the new mirror feature and also fixes lei based patchwork instance support.