Fix nnx object state

[divyashreepathihalli]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @divyashreepathihalli, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented a fix to how Keras operations manage their internal state when the JAX backend is active and NNX is enabled. This change ensures that the state is handled using PytreeState from flax.nnx.pytreelib, aligning with JAX's pytree conventions for more robust and efficient state management.

Highlights

• JAX/NNX State Initialization: The initialization of the internal state for Keras operations has been updated. Previously, nnx.object.ObjectState() was used, but this has been replaced with nnx.pytreelib.PytreeState(). Additionally, the internal variable name _object__state was updated to _pytree__state to reflect this change.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be a fix for compatibility with Flax NNX, updating how an Operation instance is treated as a Pytree when using the JAX backend. The change replaces a likely outdated attribute and object from nnx.object with a new one from nnx.pytreelib. While this seems correct, I've added one comment regarding the potential use of an internal API, which could be a maintainability concern.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.75%. Comparing base (5d50953) to head (e17f7ec).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
keras/src/ops/operation.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21565      +/-   ##
==========================================
+ Coverage   82.73%   82.75%   +0.01%     
==========================================
  Files         567      567              
  Lines       56464    56471       +7     
  Branches     8825     8818       -7     
==========================================
+ Hits        46718    46730      +12     
+ Misses       7582     7580       -2     
+ Partials     2164     2161       -3     

Flag	Coverage Δ
keras	82.55% <0.00%> (+0.01%)	⬆️
keras-jax	63.78% <0.00%> (-0.04%)	⬇️
keras-numpy	58.29% <0.00%> (-0.01%)	⬇️
keras-openvino	34.67% <0.00%> (+0.03%)	⬆️
keras-tensorflow	64.21% <0.00%> (-0.04%)	⬇️
keras-torch	63.83% <0.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[divyashreepathihalli]

https://colab.sandbox.google.com/drive/1hs87dOeYzsByWmy4Pv2dc51pZ4G6CclW#scrollTo=S6hRZBS8OT5i