Skip to content

Conversation

dayo09
Copy link
Contributor

@dayo09 dayo09 commented Jun 2, 2025

Let's fix comment in AveragePooling2D.

Copy link

google-cla bot commented Jun 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

(when `input_shape >= pool_size`)
The resulting output shape when using the `"same"` padding option is:
`output_shape = math.floor((input_shape - 1) / strides) + 1`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is about valid padding. Let's fix this to represent same padding.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (3d2db56) to head (116cc07).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21340   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         565      565           
  Lines       54825    54825           
  Branches     8515     8515           
=======================================
  Hits        45333    45333           
  Misses       7406     7406           
  Partials     2086     2086           
Flag Coverage Δ
keras 82.49% <ø> (ø)
keras-jax 63.64% <ø> (ø)
keras-numpy 58.77% <ø> (-0.01%) ⬇️
keras-openvino 33.13% <ø> (ø)
keras-tensorflow 64.03% <ø> (ø)
keras-torch 63.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Let's fix comment in AveragePooling2D.

Signed-off-by: Dayoung Lee <[email protected]>
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 2, 2025
@fchollet fchollet merged commit c7b66fc into keras-team:master Jun 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants