Skip to content

[OpenVINO backend] Support numpy.empty #21010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025
Merged

[OpenVINO backend] Support numpy.empty #21010

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11cd909
[OpenVINO Backend] numpy.empty implementation
arkhamHack Mar 11, 2025
22208ac
fix: reformatted
arkhamHack Mar 11, 2025
98b25f1
fix: fixed final lint issues
arkhamHack Mar 11, 2025
1e1262b
fix: updated empty logic
arkhamHack Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion keras/src/backend/openvino/excluded_concrete_tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ NumpyDtypeTest::test_diag
NumpyDtypeTest::test_diff
NumpyDtypeTest::test_digitize
NumpyDtypeTest::test_einsum
NumpyDtypeTest::test_empty
NumpyDtypeTest::test_exp2
NumpyDtypeTest::test_expm1
NumpyDtypeTest::test_eye
Expand Down
11 changes: 10 additions & 1 deletion keras/src/backend/openvino/numpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,16 @@ def dot(x, y):


def empty(shape, dtype=None):
raise NotImplementedError("`empty` is not supported with openvino backend")
if dtype is not None:
ov_type = OPENVINO_DTYPES[standardize_dtype(dtype)]
else:
ov_type = Type.f32
if isinstance(shape, tuple):
shape = list(shape)
elif isinstance(shape, int):
shape = [shape]
empty_tensor = ov_opset.parameter(shape, ov_type).output(0)
return OpenVINOKerasTensor(empty_tensor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct implementation:)
Now you are adding parameter that is a new input to model.

Please check how it is implemented for other backends and try to interpret it.

Copy link
Contributor Author

@arkhamHack arkhamHack Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so I noticed in tensorflow backend they return a shape matrix of zeroes. Should i implement the same? The main issue here was returning a unintialized shape (with garbage values) or array like in numpy empty. Couldn't find any good opset for that in openvino. Also checked jax they are also returning zeroes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkazants do let me know if this is okay, i'll push the changes in that case. Thanks :)



def equal(x1, x2):
Expand Down