Skip to content

Conversation

@LuNoX
Copy link
Contributor

@LuNoX LuNoX commented Jan 12, 2023

Resolves #812

All BaseClass definitions have been updated to Python3 style.
Previously, all BaseClasses were defined in a Python2 style having an explicit inheritance from object. This is no longer recommended with Python3.
As a result, all BaseClass definitions were changed to Python3 style.

All BaseClass definitions have been updated to Python3 style.
Previously, all BaseClasses were defined in a Python2 style having an explicit inheritance from object. This is no longer recommended with Python3.
As a result, all BaseClass definitions were changed to Python3 style.
Copy link
Collaborator

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 95.23% // Head: 95.23% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (31637f5) compared to base (d07a23e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   95.23%   95.23%   -0.01%     
==========================================
  Files          50       50              
  Lines        3168     3167       -1     
==========================================
- Hits         3017     3016       -1     
  Misses        151      151              
Impacted Files Coverage Δ
keras_tuner/engine/conditions.py 88.46% <ø> (-0.22%) ⬇️
keras_tuner/distribute/oracle_client.py 95.65% <100.00%> (ø)
keras_tuner/engine/hypermodel.py 100.00% <100.00%> (ø)
...ras_tuner/engine/hyperparameters/hyperparameter.py 100.00% <100.00%> (ø)
...as_tuner/engine/hyperparameters/hyperparameters.py 100.00% <100.00%> (ø)
keras_tuner/engine/logger.py 80.35% <100.00%> (ø)
keras_tuner/engine/metrics_tracking.py 98.27% <100.00%> (ø)
keras_tuner/engine/stateful.py 100.00% <100.00%> (ø)
keras_tuner/engine/tuner_utils.py 88.58% <100.00%> (ø)
keras_tuner/protos/service_pb2_grpc.py 62.16% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@haifeng-jin haifeng-jin merged commit 1f42618 into keras-team:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change all Py2 style class definition to Py3 style

2 participants