Skip to content

Conversation

@TannerGabriel
Copy link
Contributor

This PR

  • Removes the distributor (code + docs)
  • Switch from sdk-go/v2 to go-sdk
  • Event handling is reduced to two events which demonstrate how events should be handled using the go-sdk

Signed-off-by: TannerGabriel <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 19, 2022

Unit Test Results

4 tests   2 ✔️  1s ⏱️
3 suites  2 💤
1 files    0

Results for commit d5d2417.

♻️ This comment has been updated with latest results.

Signed-off-by: TannerGabriel <[email protected]>
Signed-off-by: TannerGabriel <[email protected]>
Signed-off-by: TannerGabriel <[email protected]>
Signed-off-by: TannerGabriel <[email protected]>
@TannerGabriel TannerGabriel marked this pull request as ready for review July 20, 2022 13:58
Signed-off-by: TannerGabriel <[email protected]>
@TannerGabriel TannerGabriel requested review from Raffy23 and pchila July 25, 2022 08:06
@TannerGabriel TannerGabriel requested a review from Raffy23 July 26, 2022 11:21
Signed-off-by: TannerGabriel <[email protected]>
Signed-off-by: TannerGabriel <[email protected]>
@TannerGabriel TannerGabriel requested a review from Raffy23 August 10, 2022 05:53
@github-actions
Copy link

The following Docker Images have been built:
ghcr.io/keptn-sandbox/keptn-service-template-go:0.17.1-dev-PR-159,ghcr.io/keptn-sandbox/keptn-service-template-go:0.17.1-dev-PR-159.202208100552

Copy link
Member

@Raffy23 Raffy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TannerGabriel TannerGabriel merged commit 8aafd2c into main Aug 10, 2022
@TannerGabriel TannerGabriel deleted the feat/go-sdk-remote-execution-plane branch August 10, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants