Fix extra cloned slides [Fixes #3691] #3845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This for loop iterates over too many slides. In fact it iterates beyond the number of slides but jQuery fails silently once it exceeds the slides. The result is that too many slides get cloned and appended to the end of the track. This previously caused issues fixed with [kenwheeler#3809]. This remaining fix is a minor performance improvement by trimming out the cloned slides that are never visible.
Netopya
changed the title
Netopya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When infinite is enabled, the loop that generates the cloned slides to be appended to the end of the track iterates over too many slides. In fact it iterates beyond the number of slides but jQuery fails silently once it exceeds the slides. The result is that too many slides get cloned and appended to the end of the track. This previously caused issues fixed with [#3809]. This remaining fix cleans up the DOM by trimming out the cloned slides that are never visible.
Original Issue:
http://jsfiddle.net/MrCroissant1/xrgkL8nu/4/
Notice how all the slides from the slider are cloned as the end of the track
With fix:
http://jsfiddle.net/MrCroissant1/79yunkeq/1/
Notice how only the first slide is cloned at the end of the slide, which is all we need since slidesToShow is just 1.