Skip to content

Use proxyquire to mock fs object ... #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2016
Merged

Use proxyquire to mock fs object ... #8

merged 3 commits into from
Mar 17, 2016

Conversation

ta2edchimp
Copy link
Collaborator

Supersedes #7

Kent C. Dodds and others added 2 commits March 16, 2016 16:34
This reproduces a bug in AVA (maybe?). Just run $ npm t and you'll …
91a3b9b 
…get:

(node) warning: possible EventEmitter memory leak detected. 11 test listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at TestCollection.addListener (events.js:239:17)
    at Runner.run (/Users/kdodds/Developer/eslint-find-new-rules/node_modules/ava/lib/runner.js:127:13)
    at process.<anonymous> (/Users/kdodds/Developer/eslint-find-new-rules/node_modules/ava/index.js:90:10)
    at emitOne (events.js:77:13)
    at process.emit (events.js:169:7)
    at process.<anonymous> (/Users/kdodds/Developer/eslint-find-new-rules/node_modules/ava/lib/test-worker.js:124:10)
    at emitTwo (events.js:87:13)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:689:10)
    at Pipe.channel.onread (internal/child_process.js:440:11)
@ta2edchimp
fix(tests): Use proxyquire to mock fs object instead of mocking the f…
7f96704 
…ilesystem.
@codecov-io
Copy link

Current coverage is 100.00%

Merging #8 into master will increase coverage by +27.28% as of 84a7015

@@            master      #8   diff @@
======================================
  Files            2       1     -1
  Stmts           22       7    -15
  Branches         0       0       
  Methods          0       0       
======================================
- Hit             16       7     -9
  Partial          0       0       
+ Missed           6       0     -6

Review entire Coverage Diff as of 84a7015

Powered by Codecov. Updated on successful CI builds.

@ta2edchimp ta2edchimp mentioned this pull request Mar 17, 2016
Closed
@kentcdodds
Copy link
Owner

Somehow this causes bin to fall out of coverage reporting... Will look into this before merging...

kentcdodds
kentcdodds reviewed Mar 17, 2016
View reviewed changes
test/bin.js
test.todo('test bin later')

try {
require('./bin') // requiring now for coverage until this is tested
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update your PR to require('../bin') :-) That'll fix the coverage issue :-) Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Pushes the percentage of covered statements und lines just above the set threshold :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

kentcdodds pushed a commit that referenced this pull request Mar 17, 2016
Merge pull request #8 from ta2edchimp/ava-bug
1af8dc1 
Use proxyquire to mock fs object ...
@kentcdodds kentcdodds merged commit 1af8dc1 into kentcdodds:master Mar 17, 2016
@kentcdodds
Copy link
Owner

Wanna add yourself to the contributors? https://github.com/kentcdodds/eslint-find-new-rules/blob/master/.all-contributorsrc more info

@kentcdodds
Copy link
Owner

I've given you write access to the repo. Please keep doing PRs (and I will too) rather than committing directly to master :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ta2edchimp @codecov-io @kentcdodds