Fix inheriting browser group settings #12368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
force-pushed
the
fix/inherit_browser_group_settings
branch
from
f912394 to
d5dc203
Compare
|
While we are here, can we adjust the labels on these settings? They are really hard to parse:
Should be:
Something like that |
Then "Skip Auto-Submit" would be "Skip / Don't skip", "Use entries with HTTP Basic Auth" would be "Use / Don't use".. I'd rather keep the simple "Enable / Disable" here and use the verbs in the labels. |
|
Whatever makes it clear |
droidmonkey
approved these changes
Aug 10, 2025
|
We can adjust the labels later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inheriting browser related group settings. The
TriStateenum was actually casted tobooleanvalues. The boolean value must be properly parsed based on theTriStatesetting, similar to what Search and Auto-Type settings are doing.Fixes #12360
Testing strategy
Manually, creating a new group with subgroup, and subgroups subgroups, with different group settings.
Type of change