-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add URL auto-type and copy options to auto-type selection popup and menus #12341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds URL auto-typing and copying functionality to KeePassXC's auto-type selection popup window and main entry menus. The implementation follows existing patterns for username, password, and TOTP fields to provide consistent URL handling across the application.
Key Changes:
- Added URL auto-type options ("{URL}" and "{URL}{ENTER}") to context menus and toolbar dropdowns
- Added keyboard shortcuts Ctrl+4 for "Type {URL}" and Ctrl+Shift+4 for "Copy {URL}"
- Updated "Use Virtual Keyboard" shortcut from Ctrl+4 to Ctrl+5 to avoid conflicts
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/gui/MainWindow.ui | Defines new UI actions for URL auto-type functionality |
src/gui/MainWindow.cpp | Implements URL auto-type actions in main window menus and connects signals |
src/gui/DatabaseWidget.h | Declares new URL auto-type method signatures |
src/gui/DatabaseWidget.cpp | Implements URL auto-type methods that call performAutoType with URL templates |
src/autotype/AutoTypeSelectDialog.ui | Updates help text to show new Ctrl+4 URL shortcut and Ctrl+5 virtual keyboard |
src/autotype/AutoTypeSelectDialog.cpp | Adds URL field support to auto-type selection dialog context menu |
share/translations/keepassxc_en.ts | Adds translation strings for new URL-related menu items |
I'd like to propose an addition to this PR. This addition could be introduced as a separate/standalone PR too, if that would be a better approach. The commit for this feature can be found in here: This also adds ability to Column Filtering mode to search by URL. Here below is a technical summary about the addition: Technical Summary: Add URL Column to Auto-Type Selection DialogFeature OverviewThis feature adds a new URL column to the auto-type selection popup window, displaying each entry's URL field alongside the existing Group, Title, Username, and Sequence columns. The URL column is positioned as the last column (index 4) after the Sequence column. AI DisclosureAI Disclosure: This pull request was created with assistance from Copilot AI (Claude Sonnet 4 language model) for code generation and implementation guidance. Implementation DetailsFiles Modified
|
The URL column is very specific and usually not relevant to auto-type. There is a request for showing more columns in the auto-type dialog: #11389 and #1416 Let's save column adjustments for another PR, one that also let's users decide which columns to show (right click menu) and saves the state of those columns in settings. |
Co-authored-by: juzu-o <[email protected]>
Co-authored-by: juzu-o <[email protected]>
…opdown Co-authored-by: juzu-o <[email protected]>
Co-authored-by: juzu-o <[email protected]>
…enus (keepassxreboot#12341) * Added "Type {URL}" option to the auto-type selection popup right-click context menu * Added "Copy {URL}" option to the auto-type selection popup right-click context menu * Added keyboard shortcuts: CTRL+4 for "Type {URL}" and CTRL+SHIFT+4 for "Copy {URL}" * Updated "Use Virtual Keyboard" shortcut from CTRL+4 to CTRL+5 to avoid inconsistency with order of shortcuts * Added URL auto-type options "{URL}" and "{URL}{ENTER}" to main window entry view right-click menu * Added URL auto-type options "{URL}" and "{URL}{ENTER}" to toolbar auto-type button dropdown menu * Added translation strings for "Type {URL}" and "Copy {URL}" to support internationalization --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: juzu-o <[email protected]> Co-authored-by: Jonathan White <[email protected]>
…enus (keepassxreboot#12341) * Added "Type {URL}" option to the auto-type selection popup right-click context menu * Added "Copy {URL}" option to the auto-type selection popup right-click context menu * Added keyboard shortcuts: CTRL+4 for "Type {URL}" and CTRL+SHIFT+4 for "Copy {URL}" * Updated "Use Virtual Keyboard" shortcut from CTRL+4 to CTRL+5 to avoid inconsistency with order of shortcuts * Added URL auto-type options "{URL}" and "{URL}{ENTER}" to main window entry view right-click menu * Added URL auto-type options "{URL}" and "{URL}{ENTER}" to toolbar auto-type button dropdown menu * Added translation strings for "Type {URL}" and "Copy {URL}" to support internationalization --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: juzu-o <[email protected]> Co-authored-by: Jonathan White <[email protected]>
Description
This pull request adds URL auto-typing and copying functionality to KeePassXC's auto-type selection popup window to address the missing URL options in the auto-type feature.
Changes implemented:
The implementation follows the existing patterns used for username and password auto-type/copy functionality, ensuring consistency across the application. URL options are placed after existing auto-type options (username, password, TOTP) and are properly disabled when entries don't have URL fields.
Fixes #12315
AI Disclosure: This pull request was created with assistance from Copilot AI (Claude Sonnet 4 language model) for code generation and implementation guidance.
Screenshots
Testing strategy
Manual Testing Performed:
Type of change