240418 dev #7
Open
240418 dev #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdlong
reviewed
Apr 18, 2024
scripts/histmakers/w_z_gen_dists.py
Outdated
| @@ -171,7 +174,7 @@ def build_graph(df, dataset): | |||
| axis_ewMll = hist.axis.Variable(massBins, name = "ewMll", underflow=False) | |||
| axis_ewPtll = hist.axis.Variable(common.ptV_binning, underflow=False, name = "ewPTll") | |||
| axis_ewAbsYll = hist.axis.Regular(50, 0, 5, name = "ewAbsYll") | |||
| df = theory_tools.define_dressed_vars(df, mode="wmass" if isW else "dilepton") | |||
| df = theory_tools.define_dressed_vars(df, mode="wmass" if isW else "wlike") | |||
There was a problem hiding this comment.
Most of the time when people run the gen histmaker I would expect them to want dilepton observables.
kdlong
reviewed
Apr 18, 2024
scripts/histmakers/w_z_gen_dists.py
Outdated
| axis_eta = hist.axis.Regular(25, 0, 2.5, name = "postfsrLep_absEta", overflow=True, underflow=False) | ||
| axis_pt = hist.axis.Regular(50, 20, 70, name = "postfsrLep_pt", overflow=True, underflow=True) | ||
| results.append(df_fiducial.HistoBoost("nominal_postfsr", [axis_eta, axis_pt], ["postfsrLep_absEta", "postfsrLep_pt", "nominal_weight"], storage=hist.storage.Weight())) | ||
| if args.applySelection: |
There was a problem hiding this comment.
I think it's probably easier to just set the lepton type in the gen script and then make one or the other.
kdlong
pushed a commit
that referenced
this pull request
Jul 4, 2025
add flag for physics model of the fitresult used as input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.