Add validation to FrontProxy to ensure that OIDC requires ServiceAccount auth #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt auth On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
kind/cleanup
|
/lgtm |
|
LGTM label has been added. Git tree hash: 991537410262a7df34b16f2903e5953311b8b3d7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/retest flake? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small PR to prevent misconfiguration of front-proxy instances. When OIDC authN is enabled, ServiceAccount tokens need to be authenticated by the front-proxy as well, as all JWT tokens will be processed (and rejected, if unknown) by the front-proxy component otherwise.
What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #
Release Notes