Skip to content

feat: add net.CIDR_subnets function #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

johngmyers
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1857

2. What is the scope of this PR (e.g. component or file name):

kclvm/runtine/src/net

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Adds a function to allocate multiple networks out of a CIDR.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@johngmyers johngmyers force-pushed the subnets branch 2 times, most recently from 4ff4571 to f1f6a16 Compare April 16, 2025 03:45
Signed-off-by: John Gardiner Myers <[email protected]>
@johngmyers johngmyers marked this pull request as ready for review April 16, 2025 04:35
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14484569177

Details

  • 220 of 296 (74.32%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 70.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/net/mod.rs 219 295 74.24%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/net/mod.rs 1 58.48%
kclvm/sema/src/advanced_resolver/node.rs 1 84.97%
Totals Coverage Status
Change from base Build 14460419160: 0.06%
Covered Lines: 53521
Relevant Lines: 75877

💛 - Coveralls

@Peefy Peefy merged commit ac4f8bc into kcl-lang:main Apr 16, 2025
13 checks passed
@johngmyers johngmyers deleted the subnets branch April 16, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants