Skip to content

Conversation

@TrentBrick
Copy link

I realized that the concatenation operation for the AffineHalfFlow is not correct given the even odd masking that occurs. I have implemented a simple fix for this.

@janosh
Copy link

janosh commented Feb 9, 2020

Or you could do x0, x1 = x.chunk(2, dim=1) and leave z = torch.cat([z0, z1], dim=1) as is. See the note on cats inverse operation here.

@XuebinZhaoZXB
Copy link

I realized that the concatenation operation for the AffineHalfFlow is not correct given the even odd masking that occurs. I have implemented a simple fix for this.

Can we treat this even odd thing as a permutation matrix operation to the original input vector x, and the |log_det| of this operation is 0, then this would not be a bug here (For my own problem, I found the result of this is better than simply: x0, x1 = x.chunk(2, dim = 1) and then using z = torch.cat([z0, z1], dim = 1).
Any other got the similar result here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants