Unable to upload any files as custom attachments on v0.28

[kennethso168]

Describe the Bug

Supposedly, 0.28.0 merged #2100 allowing any file type for user uploads. However, I'm still unable to upload text attachments, only limited type of attachments such as pictures

Steps to Reproduce

1. Preview an article
2. Expand Attachments and Click "upload file"
3. Upload a file with text file type (e.g. .txt, .yml)
4. An error "Unsupported Asset Type" is shown
5. Previously allowed file types (e.g. .png) can still be uploaded

Expected Behaviour

Any file types should be able to be uploaded

Screenshots or Additional Context

Well, I guess AI also got this in the PR: #2100 (comment)

Device Details

Firefox 145.0.1 on Windows 11

Exact Karakeep Version

v0.28.0

Have you checked the troubleshooting guide?

• I have checked the troubleshooting guide and I haven't found a solution to my problem

[MohamedBassem]

Currently, uploaded types needs to be explicitly allowlisted. This is the current list of allowed types:

karakeep/packages/shared/assetdb.ts

Lines 49 to 55 in c5c71ba

	// The assets that we allow the users to upload
	export const SUPPORTED_UPLOAD_ASSET_TYPES: Set<string> = new Set<string>([
	...IMAGE_ASSET_TYPES,
	...VIDEO_ASSET_TYPES,
	ASSET_TYPES.TEXT_HTML,
	ASSET_TYPES.APPLICATION_PDF,
	]);

Happy to accept PRs to expand this lists with more time as needed. Yaml and text files sound like reasonable attachment types.

[kennethso168]

Thanks for the quick reply. The yaml and text files have MIME type text/plain and I can do a quick PR

I'm just curious about why the uploaded types needs to be explicitly allowlisted and do you have any rationale for determining which types are "reasonable"?