Skip to content

chore!: removing unused dependencies and implementing logging #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 29, 2024
Merged

chore!: removing unused dependencies and implementing logging #2

merged 16 commits into from
Feb 29, 2024

Conversation

@ikr4-m
Copy link
Contributor

@ikr4-m ikr4-m commented Feb 29, 2024 •
edited
Loading

  • Removing zValidator from hono/zod-validator to handling manually. My target is developer can easily modify error message on src/*Error with free.
  • Implementing pino and pino-pretty for logging. As default, pino-pretty will be enabled if developer set the NODE_ENV to development or dev.
  • Fixing some false import ofc.
  • There's still more TODO but will be updated on next patch.

ikr4-m added 15 commits February 26, 2024 00:14
@ikr4-m
fix(app/function): false import
65c6846
@ikr4-m
feat(app/decorator): new validator decorator and implement it
8382379
@ikr4-m
fix(app/types): fix Input decorator
8d25b98 
It's fucked up using Partial...
@ikr4-m
refactor(app/controller): extend Todo target
7089d76
@ikr4-m
refactor(app/controller): extend Todo target
f0714d9
@ikr4-m
refactor(app/decorator/validator): improve typing for zod validator
1da1a87
@ikr4-m
refactor(app/controller): move the typing
3dd312c
@ikr4-m
Merge branch 'kakushindev:main' into main
a6a725d
@ikr4-m
refactor(app): move app function to base function
9ba48e8
@ikr4-m
refactor(error): add some json validating
b46b496
@ikr4-m
feat(app/error): improving onError
322434e
@ikr4-m
refactor(error): ambigous prop key
ecafa2c
@ikr4-m
deps: add logger and implementing it
c3725ab
@ikr4-m
feat(app/error): implementing pino on logging error
2c7e98b
@ikr4-m
refactor(env): add example of environment variable
44415f5
@changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc534b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ikr4-m ikr4-m self-assigned this Feb 29, 2024
@ikr4-m ikr4-m added the enhancement New feature or request label Feb 29, 2024
@ikr4-m ikr4-m requested a review from KagChi February 29, 2024 06:48
KagChi
KagChi requested changes Feb 29, 2024
View reviewed changes
@ikr4-m ikr4-m merged commit 92370fc into kakushindev:main Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hazmi35 Hazmi35 Hazmi35 approved these changes

@KagChi KagChi KagChi approved these changes

@satoufuyuki satoufuyuki Awaiting requested review from satoufuyuki

Assignees

@ikr4-m ikr4-m

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikr4-m @Hazmi35 @KagChi