Skip to content

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Nov 3, 2025

Description

As of Kubernetes v1.34, the kube-apiserver expects to manage etcd-style compaction itself and observes a "compaction revision" key to coordinate cache pruning.

If Kine continues compacting independently, it can race the API server's own compaction logic. Disable Kine's automatic compaction by passing --compact-interval=0 so that the API server has full control.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

As of Kubernetes v1.34, the kube-apiserver expects to manage etcd-style
compaction itself and observes a "compaction revision" key to coordinate
cache pruning.

If Kine continues compacting independently, it can race the API server's
own compaction logic. Disable Kine's automatic compaction by passing
--compact-interval=0 so that the API server has full control.

See: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/4988-snapshottable-api-server-cache/README.md
See: k3s-io/kine#513
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added area/controlplane component/kine backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch labels Nov 3, 2025
@twz123 twz123 marked this pull request as ready for review November 3, 2025 11:36
@twz123 twz123 requested review from a team as code owners November 3, 2025 11:36
@twz123 twz123 requested review from jnummelin and kke November 3, 2025 11:36
@twz123 twz123 merged commit 7bb4b69 into k0sproject:main Nov 13, 2025
203 of 204 checks passed
@twz123 twz123 deleted the kine-compact-interval branch November 13, 2025 14:12
@k0s-bot
Copy link
Contributor

k0s-bot commented Nov 13, 2025

Successfully created backport PR for release-1.34:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controlplane backport/release-1.34 PR that needs to be backported/cherrypicked to the release-1.34 branch component/kine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants