Added ExtraArgs to kine

[psaradhi]

Added ExtraArgs to kine
Modified static clusterconfigs.yaml to update the sample config to include extrArgs for Kine

Description

Fixes #5182

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

Checklist

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[juanluisvaladas]

Hi @psaradhi,

First of all, thanks for the pull request.

I haven't had a proper look at the PR yet but the couple checks failing:

1- The DCO check verifies that all your commits are signed off. To sign off the commits the commit must include Signed-off-by: NAME <EMAIL>at the bottom. You can do this with git commit -s, to do it in an existing commit you can use git commit --amend -s

2- The linter fails because you didn't include in the commit the autogenerated code. if you run make the Makefile will generate all these files for you, please make sure to include the pull request.

Also I see you closed the first pull request and opened a second one. You don't need to do this to make modifications, you can modify your local branch and push it to github again. You can also use git push --force if some changes aren't just adding but overwriting previous commits.

Finally, this change would require a documentation update. You can check previous similar PRs as a reference:

• https://github.com/k0sproject/k0s/pull/3902/files
• https://github.com/k0sproject/k0s/pull/5055/files

[juanluisvaladas]

The DCO error is legit, (you have to squash and sign off your commits). Don't worry about the etcdmember smoketest (it's flaky and unrelated to you) and the Go lint/Validate OS tests is due to a problem github had this morning.

We need to discuss it internally but other than the DCO I think this is OK

[twz123]

This probably needs a small change to the docs in configuration.md, too.

[psaradhi]

@juanluisvaladas

1. I squashed all commits into one and pushed the changes
2. Signed off the commit
3. Modified configuration.md to include extraArgs for Kine

Please review

[twz123]

@psaradhi Thanks. I think we need to revisit the switch statement, though.

[psaradhi]

@twz123

You are absolutely right about the switch and issue continue. I removed it.

[cgroschupp]

@psaradhi I created a PR, but then closed it in favour of yours. I added the extraArgs parameter to the TestKinePartialConfigLoading test and noticed that the DataSource doesn't take the default value. You can see my fix here: cgroschupp@8c9f80c

[twz123]

Thanks @psaradhi! Would you mind raising another PR with your fix, @cgroschupp, or would you be okay with me cherry-picking it myself?

[cgroschupp]

@twz123 it is better to add some tests to this PR.

[github-actions]

This pull request has merge conflicts that need to be resolved.

[psaradhi]

@twz123 - apologies for not being active for the last few days. I think @cgroschupp had the tests in the PR.. Should I add the same tests ? or will you cherry pick those tests ? what is expected from me to complete this PR ?

[cgroschupp]

The PR checklist is clear on this point

I have added tests that prove my fix is effective or that my feature works

@psaradhi please add the tests to prove your feature.

[twz123]

@psaradhi Yes, please cherry-pick the tests here. Also, this PR needs a rebase, since it has a merge conflict.