-
Notifications
You must be signed in to change notification settings - Fork 27
More consistent naming #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1, especially while we're still pretty small and growing. Just double checking - is it consistently |
I don't have permission to merge, but I can approve. Thanks! |
You should have received an invitation to the jupyterlite org and for having commit rights on this repo :) You probably need to accept it. I let you merge then! :) |
On second thought, I looked through the jupyterlite repo, and they are more consistently treating jupyterlite as one word in the code, even if the config file naming is treating jupyterlite as two words. I think we ought to hold off on the breaking change here to get more clarity on which way we should consistently name things. It may be that they decide to change jupyterlite to have the config file be named |
Probably this is unlikely to change in jupyterlite, and I believe |
Thanks for chiming in, and for some of the context. |
After thinking about this more and sleeping on it, I was thinking that maybe it makes sense to have the filename be |
Arf sorry I merged so fast then :S I agree with you, let's revert and release again. |
+1 - I think this would be 0.6.0, since this is technically breaking the 0.5.0 api. I don't think we need to put in backwards compatible shims, though, on the thought that most people would not have upgraded to 0.5.0. |
In jupyterlite#62, we reverted the config name changes from jupyterlite#58. However, we forgot to revert the changes to our docs conf.py config as well.
Fix #57
cc. @jasongrout