Skip to content

Fix invalid schema for jupyterlite_sphinx_strip tag when strip_tagged_cells is True #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

agriyakhetarpal
Copy link
Member

Description

"metadata": {
        "tags": [
          "jupyterlite_sphinx_strip": "true"
        ]
      }

is invalid for notebook-based metadata, while "jupyterlite_sphinx_strip" is valid. This was incorrectly mentioned in the documentation and was not caught because we were trying to parse the cell metadata itself. We now check for the existence of a tag in the metadata rather than trying to find it as a key-value pair in the metadata for a cell. This is a fix that is a candidate for a v0.16.1 release.


cc: @steppi

@steppi steppi added the bug Something isn't working label Jul 18, 2024
Copy link
Collaborator

@steppi steppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @agriyakhetarpal. Thanks for catching this early.

@steppi steppi merged commit a9c704e into jupyterlite:main Jul 18, 2024
5 of 6 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/invalid-tags branch July 18, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants