Improve accessibility for menu items with toggle state #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
added
bug
krassowski
approved these changes
Apr 29, 2025
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
I think ideally the role for menu entries which can be toggled would always have menuitemcheckbox role, not only when they are toggled. I appreciate it is not trivial to achieve with the information available on menu items right now so it would require a larger change. I think this PR is a significant improvement as-is though.
The workflow failures are unrelated and will be fixed with #754
krassowski
changed the title
Contributor
Author
|
Thank you, @krassowski. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal on how to fix the issue: jupyterlab/jupyterlab#17501
This was found when working on another accessibility issue. PR: jupyterlab/jupyterlab#17472
References used:
https://www.w3.org/TR/wai-aria/states_and_properties#introstates
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/menuitemcheckbox_role
@krassowski ^