Skip to content

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Jun 10, 2025

Description

This PR upgrades to jupyterlab_chat to use jupyter_collaboration~=4.0.

@andrii-i will help test this PR and leave feedback in the comments below.

Note: We would like a release/pre-release including this PR soon. This PR can be safely reverted / modified afterwards if necessary since we are still on v0.

@dlqqq dlqqq added the enhancement New feature or request label Jun 10, 2025
Copy link
Contributor

Binder 👈 Launch a Binder on branch dlqqq/jupyter-chat/upgrade-jcollab-4

@dlqqq dlqqq force-pushed the upgrade-jcollab-4 branch from feb4f9b to f8cb9e0 Compare June 10, 2025 21:21
@dlqqq dlqqq force-pushed the upgrade-jcollab-4 branch from f8cb9e0 to 8ed856c Compare June 10, 2025 21:22
@andrii-i andrii-i force-pushed the upgrade-jcollab-4 branch from 8db15a8 to fef69a3 Compare June 10, 2025 23:06
@andrii-i andrii-i force-pushed the upgrade-jcollab-4 branch from f15e159 to 0f8865e Compare June 10, 2025 23:23
@andrii-i andrii-i requested a review from krassowski June 10, 2025 23:35
@andrii-i andrii-i requested a review from brichet June 11, 2025 00:00
Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green and I've tested main user flows is this PR locally: creating a chat, chatting with multiple users (all from 1 PC though) in side panel and in main panel, editing messages, deleting messages works well.

So this PR looks good to me. At the same time I've authored a large part of it so it could definitely use more reviews.

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

For the context, what is the benefit of upgrading jupyter_collaboration? I understand this is for jupyter-ai, but I miss some context. Is this to remove the RTC: prefix ?

Also I wonder if we should keep a branch compatible with jupyter_collaboration v3, before moving forward with v4 ?

andrii-i and others added 2 commits June 11, 2025 06:47
…4, lumino packages to latest versions used in JupyterLab 4.4
@andrii-i andrii-i force-pushed the upgrade-jcollab-4 branch from 0222174 to e4279e3 Compare June 11, 2025 16:53
@andrii-i andrii-i force-pushed the upgrade-jcollab-4 branch from 495e6f3 to 0b69026 Compare June 11, 2025 16:55
@andrii-i andrii-i requested a review from brichet June 11, 2025 17:12
@andrii-i
Copy link
Collaborator

andrii-i commented Jun 11, 2025

@brichet thank you for looking into this. jupyter-collaboration v4 brings a bunch of improvements to stability and bug fixes but update of @jupyter/collaborative-drive to v4 and associated use of content providers to remove RTC prefix that you mention is definitely one of the major ones (it also moves tokens to JupyterLab, changes tokens used, and introduces dependency on JupyterLab 4). I wasn’t able to find one place that summarizes all jupyter-collaboration v4 changes but they can be seen in the history of commits and PR descriptions https://github.com/jupyterlab/jupyter-collaboration/commits/main/.

I have also just created a 0.12.x branch https://github.com/jupyterlab/jupyter-chat/tree/0.12.x to keep a branch compatible with jupyter_collaboration v3 just in case as you suggest and bumped @jupyterlab, @lumino package versions, ts version, @notebook packages to ones used in JupyterLab 4.4.

Package updates necessitated adding a small mock for testing so I also implemented that.

All in all, CI is green and this PR is ready for final review and merge.

@dlqqq
Copy link
Member Author

dlqqq commented Jun 11, 2025

Andrii's updates look good to me as well. Can't approve since I was the one who opened this PR.

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @dlqqq @andrii-i

@brichet brichet merged commit 2b688d7 into jupyterlab:main Jun 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants