-
-
Notifications
You must be signed in to change notification settings - Fork 16
Upgrade to Jupyter Collaboration 4 #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: David L. Qiu <[email protected]>
8db15a8
to
fef69a3
Compare
f15e159
to
0f8865e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green and I've tested main user flows is this PR locally: creating a chat, chatting with multiple users (all from 1 PC though) in side panel and in main panel, editing messages, deleting messages works well.
So this PR looks good to me. At the same time I've authored a large part of it so it could definitely use more reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
For the context, what is the benefit of upgrading jupyter_collaboration
? I understand this is for jupyter-ai
, but I miss some context. Is this to remove the RTC:
prefix ?
Also I wonder if we should keep a branch compatible with jupyter_collaboration v3, before moving forward with v4 ?
Co-authored-by: Nicolas Brichet <[email protected]>
…4, lumino packages to latest versions used in JupyterLab 4.4
0222174
to
e4279e3
Compare
495e6f3
to
0b69026
Compare
@brichet thank you for looking into this. I have also just created a Package updates necessitated adding a small mock for testing so I also implemented that. All in all, CI is green and this PR is ready for final review and merge. |
Andrii's updates look good to me as well. Can't approve since I was the one who opened this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR upgrades to
jupyterlab_chat
to usejupyter_collaboration~=4.0
.@andrii-i will help test this PR and leave feedback in the comments below.
Note: We would like a release/pre-release including this PR soon. This PR can be safely reverted / modified afterwards if necessary since we are still on v0.