Doesn't work with notebook 7

[yuvipanda]

Description

I'd love for this to work with notebook 7 as well, rather than just JupyterLab. I see notebook 7 also has the 'open from URL' functionality, so hopefully it's a reasonably simple matter?

[yuvipanda]

Maybe

jupyterlab-open-url-parameter/src/index.ts

Line 12 in f216f9d

const URL_PATTERN = new RegExp('/lab/?');

?

[yuvipanda]

https://notebooksharing.space/jupyterlite/lab/?fromURL=/api/v1/notebook/003d600c569502a28ab39b0fe4d4ea16cedcdcbc400f3093d76fc5e48f061246/Demo.ipynb works, but https://notebooksharing.space/jupyterlite/tree/?fromURL=/api/v1/notebook/003d600c569502a28ab39b0fe4d4ea16cedcdcbc400f3093d76fc5e48f061246/Demo.ipynb does not

[jtpio]

Maybe

jupyterlab-open-url-parameter/src/index.ts

Line 12 in f216f9d

const URL_PATTERN = new RegExp('/lab/?');

?

Yeah that may be because of this indeed.

Notebook 7 should indeed be supported.

[yuvipanda]

@jtpio do you think you'll have any capacity to look into it? :D :D

[jtpio]

I was planning to have a look at this extension again soon anyway for another JupyterLite integration (that would also need to Notebook 7).

Quickly checking by adding tree to the regex. This kind of works but the UX is really not optimal:

jupyterlite-open-url-parameter-nb7.webm

Thinking that the simplest way for now could be to special case loading a remote file with ?fromUrl from the notebooks page in this extension, and look into fixing upstreams (lab and/or notebook) to better handle that.

[yuvipanda]

@jtpio ah interesting. Yes I agree special casing that is the way to go I think, and then can be fixed upstream as appropriate.