Switch to commands #783
Merged
Switch to commands #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
Sep 17, 2025
|
Integration tests report: appsharing.space |
|
Preview PR at appsharing.space |
martinRenou
requested changes
Sep 18, 2025
| const { commands, tracker, trans } = options; | ||
|
|
||
| commands.addCommand(ShapeCreationCommandIDs.newBoxWithParams, { | ||
| label: trans.__('New Box From Parameters'), |
There was a problem hiding this comment.
Since this is user facing, should we make this more like:
Suggested change
| label: trans.__('New Box From Parameters'), | |
| label: trans.__('Create a box'), |
There was a problem hiding this comment.
No, these commands are being used internally; users can't invoke them since there is no way to provide the required parameters
There was a problem hiding this comment.
we have user-facing commands to gather input then call these commands to do the job
|
I updated some parameter descriptions and default values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.