Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Sep 22, 2025

As noticed with recent PRs.

It's the new click: pypa/hatch#2050

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-ci-hatch

@jtpio jtpio added this to the 7.4.x milestone Sep 22, 2025
@jtpio
Copy link
Member Author

jtpio commented Sep 22, 2025

Arf, click is automatically upgraded via python -m pip install --upgrade pip pipx in:

https://github.com/jupyterlab/maintainer-tools/blob/affc83be6020d529b9368cd4d63e467877606600/.github/actions/base-setup/action.yml#L121

@jtpio jtpio changed the title Troubleshoot the failing CI Pin click<8.3 Sep 22, 2025
@jtpio jtpio marked this pull request as ready for review September 22, 2025 13:10
@jtpio
Copy link
Member Author

jtpio commented Sep 22, 2025

@jtpio
Copy link
Member Author

jtpio commented Sep 22, 2025

Moving forward with this to unblock #7728

@jtpio jtpio merged commit c0d3e8b into jupyter:main Sep 22, 2025
29 of 31 checks passed
@jtpio jtpio deleted the fix-ci-hatch branch September 22, 2025 14:38
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 22, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c0d3e8b4d6113387e9fe12f5a57350a8c20ba262
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #7729: Pin `click<8.3`'
  1. Push to a named branch:
git push YOURFORK 7.4.x:auto-backport-of-pr-7729-on-7.4.x
  1. Create a PR against branch 7.4.x, I would have named this PR:

"Backport PR #7729 on branch 7.4.x (Pin click<8.3)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jtpio jtpio mentioned this pull request Sep 22, 2025
jtpio added a commit that referenced this pull request Sep 24, 2025
This reverts commit c0d3e8b.
@jtpio jtpio mentioned this pull request Sep 24, 2025
jtpio added a commit that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant