Enable xwidgets with xeus-cpp-lite #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anutosh491
force-pushed
the
xwidgets_xeus_cpp_lite
branch
from
a4ad83e to
e78392d
Compare
anutosh491
changed the title
JohanMabille
force-pushed
the
xwidgets_xeus_cpp_lite
branch
from
e78392d to
768ccb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using xwidgets in xeus-cpp-lite through a shared build (libxwidgets.so)
The patch can be found here : emscripten-forge/recipes#2402
This PR upstreams the patch involved and would need a release to get rid of the same on emscripten-forge.