Remove confusing error message #3936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error message was introduced in jupyter-widgets#3335. It shows up when the user refreshes the JupyterLab page on a kernel that has not yet imported ipywidgets, because the manager requests for widgets states, but the kernel is not able to answer back any widget model as ipwidgets was not imported. It is a normal workflow that should not show any error message. This error message would also show up when using the manager with a kernel using ipywidgets 7, in that case as well we should not show any error message as it's a normal workflow too. This PR removes the error message to prevent any confusion from the user.
|
|
trungleduc
approved these changes
Aug 22, 2024
maartenbreddels
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error message was introduced in #3335.
It shows up when the user refreshes the JupyterLab page on a kernel that has not yet imported ipywidgets, because the manager requests for widgets states, but the kernel is not able to answer back any widget model as ipwidgets was not imported. It is a normal workflow that should not show any error message.
This error message would also show up when using the manager with a kernel using ipywidgets 7, in that case as well we should not show any error message as it's a normal workflow too.
This PR removes the error message to prevent any confusion from the user.