Skip to content

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 19, 2022

As noticed in jupyterlab/jupyterlab#12962 and jupyterlab/jupyterlab#12967, the JupyterLab UI tests were affected by the ipywidgets 8 release even though they pin on ipywidgets==7.6.5.

This had to do with jupyterlab_widgets==3 being pulled when installing ipywidgets==7.6.5.

This PR proposes pinning the version of jupyterlab_widgets for the 7.x release series to avoid mismatches.

@jtpio
Copy link
Member Author

jtpio commented Aug 19, 2022

For reference the current master branch (8.x) pins on ~=3.0:

jupyterlab_widgets~=3.0

Copy link
Member

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the 2.x version was reserved for 7.x support for lab 4. This might not be released if the lumino 2 upgrade precludes this, but it should still be safe to use <3 in the pin/

@jtpio
Copy link
Member Author

jtpio commented Aug 19, 2022

Good point, I updated the pin to jupyterlab_widgets>=1.0.0,<3 in 46b9d8d

@jasongrout
Copy link
Member

How far back should we backport this? Perhaps to 7.7 and 7.6?

@jtpio jtpio changed the title [7.x] Pin to jupyterlab_widgets>=1.0.0,<2 [7.x] Pin to jupyterlab_widgets>=1.0.0,<3 Aug 19, 2022
@jasongrout
Copy link
Member

7.6.0 was released 24 Dec 2020, so porting back to 7.6.x gives us almost about 1.5 years of support for the old 7.x releases, and corresponds to the jlab 3.0 release the day before. I think that's probably good enough. If people need to pin farther back than that, they'd have to do it anyway based on their jlab version.

tldr; I think we should backport this to 7.6.x as well.

@jtpio
Copy link
Member Author

jtpio commented Aug 19, 2022

Perhaps to 7.7 and 7.6?

Sounds good 👍

@jasongrout
Copy link
Member

I spent some time investigating the test failure, but I'm not seeing the root cause. I believe it is just in the development install, though, so given the severity of this issue, I'll go ahead and merge and release, and we can follow up about the development install.

@jasongrout jasongrout closed this Aug 19, 2022
@jasongrout jasongrout reopened this Aug 19, 2022
@jasongrout jasongrout merged commit efdfd8e into jupyter-widgets:7.x Aug 19, 2022
@jtpio jtpio deleted the pin-jupyterlab-widgets branch August 19, 2022 18:05
jasongrout added a commit to jasongrout/ipywidgets that referenced this pull request Aug 19, 2022
This makes sure we are getting an ipywidgets 7 compatible version of jupyterlab_widgets.

This backports jupyter-widgets#3551 to 7.6.x from 7.7.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants