-
Notifications
You must be signed in to change notification settings - Fork 958
[7.x] Pin to jupyterlab_widgets>=1.0.0,<3
#3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For reference the current ipywidgets/python/ipywidgets/setup.cfg Line 41 in 89026e1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the 2.x version was reserved for 7.x support for lab 4. This might not be released if the lumino 2 upgrade precludes this, but it should still be safe to use <3
in the pin/
Good point, I updated the pin to |
How far back should we backport this? Perhaps to 7.7 and 7.6? |
jupyterlab_widgets>=1.0.0,<2
jupyterlab_widgets>=1.0.0,<3
7.6.0 was released 24 Dec 2020, so porting back to 7.6.x gives us almost about 1.5 years of support for the old 7.x releases, and corresponds to the jlab 3.0 release the day before. I think that's probably good enough. If people need to pin farther back than that, they'd have to do it anyway based on their jlab version. tldr; I think we should backport this to 7.6.x as well. |
Sounds good 👍 |
I spent some time investigating the test failure, but I'm not seeing the root cause. I believe it is just in the development install, though, so given the severity of this issue, I'll go ahead and merge and release, and we can follow up about the development install. |
This makes sure we are getting an ipywidgets 7 compatible version of jupyterlab_widgets. This backports jupyter-widgets#3551 to 7.6.x from 7.7.x.
As noticed in jupyterlab/jupyterlab#12962 and jupyterlab/jupyterlab#12967, the JupyterLab UI tests were affected by the ipywidgets 8 release even though they pin on
ipywidgets==7.6.5
.This had to do with
jupyterlab_widgets==3
being pulled when installingipywidgets==7.6.5
.This PR proposes pinning the version of
jupyterlab_widgets
for the 7.x release series to avoid mismatches.