Skip to content

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Sep 2, 2021

This should be backported to 7.x as well.

See https://pypi.org/classifiers/ to see the new classifiers.

@jasongrout jasongrout added this to the 8.0 milestone Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Binder 👈 Launch a binder notebook on branch jasongrout/ipywidgets/trove

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 8a8d804 into jupyter-widgets:master Sep 2, 2021
@jtpio
Copy link
Member

jtpio commented Sep 2, 2021

@meeseeksdev please backport to 7.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 2, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 7.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 8a8d804ccc467ffbe24a5208b752f907ff0e81da
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #3265: Add new trove classifiers for JLab extensions'
  1. Push to a named branch :
git push YOURFORK 7.x:auto-backport-of-pr-3265-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #3265 on branch 7.x (Add new trove classifiers for JLab extensions)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

jtpio added a commit to jtpio/ipywidgets that referenced this pull request Sep 2, 2021
jasongrout added a commit that referenced this pull request Sep 2, 2021
Backport #3265 to 7.x (Add new trove classifiers for JLab extensions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants