Simplify max_zoom logics in Map and TileLayer #965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Apr 15, 2022
HaudinFlorence
force-pushed
the
simplify_max_zoom_logics
branch
2 times, most recently
from
1fbcc62 to
371b654
Compare
|
The changes for the attributes of Map have been made to fit with the default values in LeafletJS. According to that, zoom and center have now default values put as None. In the notebook, the user has now to give a value for both for the Map to be properly defined. |
martinRenou
requested changes
Apr 19, 2022
HaudinFlorence
force-pushed
the
simplify_max_zoom_logics
branch
3 times, most recently
from
8f8fc1d to
ebe85a2
Compare
martinRenou
requested changes
Apr 20, 2022
HaudinFlorence
force-pushed
the
simplify_max_zoom_logics
branch
2 times, most recently
from
5520e9d to
cc43ad6
Compare
martinRenou
requested changes
Apr 21, 2022
HaudinFlorence
force-pushed
the
simplify_max_zoom_logics
branch
2 times, most recently
from
fc258aa to
7a718cb
Compare
HaudinFlorence
force-pushed
the
simplify_max_zoom_logics
branch
from
7a718cb to
8cf6a7a
Compare
|
Please update galata references. Thanks |
|
Triggering CI |
|
Thanks!! |
martinRenou
added a commit
to martinRenou/ipyleaflet
that referenced
this pull request
Oct 27, 2022
davidbrochart
added a commit
that referenced
this pull request
Oct 27, 2022
Revert change from #965 that sets the default zoom to None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify max_zoom logics in Map and TileLayer.
Add changes in Map and TileLayer options to fit the one's of LeafletJS.
Updates of the related docstrings.