Skip to content

Conversation

sackh
Copy link
Contributor

@sackh sackh commented May 5, 2020

Hi @martinRenou,
I have added changes for SearchControl implementation.
Please review.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work, that's great!

@martinRenou
Copy link
Member

Let me push one final fix on your PR and that should be good to go :)

The marker should actually be view.obj in the code:

return this.create_child_view(this.model.get('marker')).then((view) => {
  let options = this.get_options();
  options.marker = view.obj;
  this.obj = L.control.search(options);
});

This way you can now assign any marker, and if the marker changes Python side it will update accordingly:
search

Let me push the change and merge the PR. It should not require any action from your side.

@martinRenou
Copy link
Member

Actually I don't seem to have the right to push to your repo. Could you please make the change? :)

@sackh
Copy link
Contributor Author

sackh commented May 9, 2020

Thanks a lot for your help. I have pushed the changes.

Signed-off-by: Kharude, Sachin <[email protected]>
@martinRenou martinRenou merged commit d38cae5 into jupyter-widgets:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants