Fix geoman controls option update + snapping option #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mangecoeur
commented
Apr 23, 2025
mangecoeur
commented
- Currently, if options are changed on the GeomanDrawControl after creation, the toolbar doesn't update. This PR adds event listeners to the model attributes to remove & re-add the draw toolbar on options change so they are reflected in the UI.
- This PR also adds the snapping option to Layers, to control which layers are used by the snapping function of Geoman.
- The version of Geoman is bumped to the latest version.
…ptions to GeoJson constructor to fetch all synced values.
…safely removed without triggering an exception.
…re-adding it in case of options changing.
… for geoman controls with implementation of Control IFace within the Geoman View via addTo
…use the same options setting method as when options dynamically change.
Closed
…to .data attr for editing. Also made circlemarker style use the draw control configured style if the feature doesn't have its own style overrides.
…her way around seems to break rendering.
…ptions to GeoJson constructor to fetch all synced values.
…safely removed without triggering an exception.
…re-adding it in case of options changing.
… for geoman controls with implementation of Control IFace within the Geoman View via addTo
…use the same options setting method as when options dynamically change.
…to .data attr for editing. Also made circlemarker style use the draw control configured style if the feature doesn't have its own style overrides.
…her way around seems to break rendering.
martinRenou
force-pushed
the
fix_geoman_controls_option_update
branch
from
6e9251b to
361c8ec
Compare
arjxn-py
reviewed
Jun 4, 2025
There was a problem hiding this comment.
Thanks a lot @mangecoeur
Just a couple of minor suggestions.
| options = model.get('marker')?.markerStyle; | ||
| } | ||
| return new L.Marker(latlng, options); | ||
| case 'circle': |
There was a problem hiding this comment.
Suggested change
| case 'circle': | |
| case 'circle': | |
| if (!options) { | |
| options = model.get('circle')?.pathOptions; | |
| } |
When i was testing it, I got options undefined everytime, so let's add a check like other cases?
Comment on lines
+551
to
+556
| this.setControlOptions(); | ||
|
|
||
| this.map_view.obj.pm.removeControls(); | ||
| if (!this.model.get('hide_controls')) { | ||
| this.map_view.obj.pm.addControls(this.controlOptions); | ||
| } |
There was a problem hiding this comment.
This part of code is also being repeated in setPosition() below, maybe you want to take it out in a separate method or if you have any better idea?
|
By the way, if you happen to have a short clip or demo showing the improvements, that would be awesome to add here too. Thanks again! |
…e' into fix_geoman_controls_option_update
|
Added some examples in the GeomanDrawControls.ipnb notebook, that just shows that you can change the control settings and the toolbar updates. Below is a short clip showing the snapping that ignores all but the chosen layer. Geoman.Snap.Demo.mp4 |
|
Thanks @mangecoeur, this is awesome!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.