-
Notifications
You must be signed in to change notification settings - Fork 52
🐛 Handle column auto fit on data model change #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Handle column auto fit on data model change #452
Conversation
18a47cc
to
3908abb
Compare
Looks like the |
I think to resolve this I need to recreate the snapshots. In the final cell this is being run: new_df = pd.DataFrame(columns=nested_df.columns, index=nested_df.index, data=np.arange(-8,8,1).reshape(4,4))
nested_grid.data = new_df Previously, the grid was not auto-fitting and the snapshot reflects that, whereas now the columns will auto-fit and therefore the snapshot will be different. I will try create some new snapshots and see if that resolves the visual tests. |
74d0e95
to
21a9695
Compare
✅ Update datagrid-nested-hierarchies-update-ipynb-cell-5-linux snapshots Signed-off-by: Oliver Hensby <[email protected]>
21a9695
to
b67699b
Compare
Hi @martinRenou, would you mind taking a quick look at this? I've just merged the current main branch into my branch and the actions YN0028: The lockfile would have been modified by this install, which is explicitly forbidden. |
It seems like your changer causes visual regressions? Did you have a look at the updated images? |
Hi @vthemelis, thanks for taking the time to look at this. I have updated the Galata images within this pull request to reflect the changes I've made and ensured the Galata tests pass successfully. However, two of the Github checks are failing when it tries to install with yarn and I am not sure why that is the case. See my previous comment for the error that is returned. |
@vthemelis any idea why the tests are failing? The PR does not introduce any changes to the dependencies/yarn. Would be great if this could make it's way into master and the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue number of the reported bug or feature request: #451
Describe your changes
When
data-model-changed
is triggered, call thehandleColumnAutoFit
method.Testing performed
Tested that the script shown in the issue runs as planned:
When setting new data, the columns are now auto fit as expected.