Skip to content

fix: do not share the Expr for text_color and background_color #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: do not share the Expr for text_color and background_color #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions ipydatagrid/cellrenderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,17 @@
from bqplot import ColorScale, Scale
from ipywidgets import Color, Widget, widget_serialization
from py2vega import Variable, py2vega
from traitlets import Any, Bool, Enum, Float, Instance, Unicode, Union, validate
from traitlets import (
Any,
Bool,
Enum,
Float,
Instance,
Unicode,
Union,
default,
validate,
)

from ._frontend import module_name, module_version

Expand Down Expand Up @@ -68,11 +78,9 @@ class TextRenderer(CellRenderer):
).tag(sync=True, **widget_serialization)
text_color = Union(
(Color(), Instance(VegaExpr), Instance(ColorScale)),
default_value=Expr("default_value"),
).tag(sync=True, **widget_serialization)
background_color = Union(
(Color(), Instance(VegaExpr), Instance(ColorScale)),
default_value=Expr("default_value"),
).tag(sync=True, **widget_serialization)
vertical_alignment = Union(
(
Expand All @@ -98,6 +106,14 @@ class TextRenderer(CellRenderer):
)
missing = Unicode("").tag(sync=True)

@default("text_color")
def _default_text_color(self):
return Expr("default_value")

@default("background_color")
def _default_background_color(self):
return Expr("default_value")


class BarRenderer(TextRenderer):
_model_name = Unicode("BarRendererModel").tag(sync=True)
Expand Down