Skip to content

CI: Fix conda setup and UI tests #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2023
Merged

CI: Fix conda setup and UI tests #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a56577
CI: Fix conda setup
martinRenou Feb 6, 2023
edbb8d8
Update Galata for UI testing
martinRenou Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,12 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Setup conda
uses: conda-incubator/setup-miniconda@v2
- name: Install Conda environment with Micromamba
uses: mamba-org/provision-with-micromamba@main
with:
activate-environment: ipydatagrid-test-ipw7
environment-name: ipydatagrid-test-ipw7
environment-file: test-environment-ipyw7.yaml
python-version: 3.9
mamba-version: '*'
auto-activate-base: false
channels: conda-forge

Expand Down Expand Up @@ -159,13 +158,12 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Setup conda
uses: conda-incubator/setup-miniconda@v2
- name: Install Conda environment with Micromamba
uses: mamba-org/provision-with-micromamba@main
with:
activate-environment: ipydatagrid-test-ipw8
environment-name: ipydatagrid-test-ipw8
environment-file: test-environment-ipyw8.yaml
python-version: 3.9
mamba-version: '*'
auto-activate-base: false
channels: conda-forge

Expand Down
2 changes: 1 addition & 1 deletion ui-tests-ipw7/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"author": "ipydatagrid",
"license": "Apache-2.0",
"dependencies": {
"@jupyterlab/galata": "~4.0.2",
"@jupyterlab/galata": "~4.5.0",
"klaw-sync": "^6.0.0",
"rimraf": "^3.0.2"
}
Expand Down
4 changes: 2 additions & 2 deletions ui-tests-ipw7/tests/ipydatagrid.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const testCellOutputs = async (page: IJupyterLabPageFixture, tmpPath: string, th
const paths = klaw(path.resolve(__dirname, './notebooks'), { filter: item => !filterUpdateNotebooks(item), nodir: true });
const notebooks = paths.map(item => path.basename(item.path));

const contextPrefix = theme == 'JupyterLab Light' ? 'light_' : 'dark_';
const contextPrefix = theme == 'JupyterLab Light' ? 'light' : 'dark';
page.theme.setTheme(theme);

for (const notebook of notebooks) {
Expand Down Expand Up @@ -55,7 +55,7 @@ const testPlotUpdates = async (page: IJupyterLabPageFixture, tmpPath: string, th
const paths = klaw(path.resolve(__dirname, './notebooks'), { filter: item => filterUpdateNotebooks(item), nodir: true });
const notebooks = paths.map(item => path.basename(item.path));

const contextPrefix = theme == 'JupyterLab Light' ? 'light_' : 'dark_';
const contextPrefix = theme == 'JupyterLab Light' ? 'light' : 'dark';
page.theme.setTheme(theme);

for (const notebook of notebooks) {
Expand Down
Loading