Major performance improvement #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change should be a no-op in terms of what the function that I changed returns. The obj argument of this recursive function is not actually used anywhere --it only appears in the recursive call and not at the base cases. `str(obj)` is a very expensive operation that we end up needlessly going through for O(rows) operations while initialising a DataGrid. This change significantly improves performance for me: Initialising a DataGrid for a DataFrame of 30k rows goes from 2.4s to 0.4s. Signed-off-by: Vasilis Themelis <[email protected]>
vthemelis
force-pushed
the
performance-regression
branch
from
9d1c3dd to
939dd6b
Compare
martinRenou
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
This str(obj) was introduced by #298 which was a bug fix for early versions of jupyter_client 7. This was later fixed in a patch version of jupyter_client so I'm fine with removing it now 👍🏽
The test that was introduced in the same PR seems to be passing.
Thanks for your PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change should be a no-op in terms of what the function that I changed returns. The obj argument of this recursive function is not actually used anywhere --it only appears in the recursive call and not at the base cases.
str(obj)is a very expensive operation that we end up needlessly going through for O(rows) operations while initialising a DataGrid.This change significantly improves performance for me: Initialising a DataGrid for a DataFrame of 30k rows goes from 2.4s to 0.4s.
Signed-off-by: Vasilis Themelis [email protected]