Skip to content

Fix Handling of Tag Lock #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Fix Handling of Tag Lock #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions jupyter_releaser/actions/draft_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,15 @@
run("pip install -e .")

run("jupyter-releaser prep-git")

# Capture the "since" argument in case we add tags before the second
# "Check Changelog"
# Do this before bumping the version
curr_dir = os.getcwd()
os.chdir(CHECKOUT_NAME)
os.environ.setdefault("RH_SINCE", get_latest_tag(os.environ["RH_BRANCH"]))
os.chdir(curr_dir)

run("jupyter-releaser bump-version")

if check_release:
Expand All @@ -40,13 +49,6 @@

run("jupyter-releaser check-changelog")

# Capture the "since" argument in case we add tags before the second
# "Check Changelog"
curr_dir = os.getcwd()
os.chdir(CHECKOUT_NAME)
os.environ.setdefault("RH_SINCE", get_latest_tag(os.environ["RH_BRANCH"]))
os.chdir(curr_dir)

# Make sure npm comes before python in case it produces
# files for the python package
run("jupyter-releaser build-npm")
Expand Down