Skip to content

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented Jul 27, 2021

Fix branch names like ft/foo or fix/bar

This happens there for example: https://github.com/fcollonval/lumino/runs/3163528043?check_suite_focus=true

+ echo 'Using GITHUB_REF: refs/heads/ft/accordion-panel'
Using GITHUB_REF: refs/heads/ft/accordion-panel
++ cut -d/ -f 3
++ echo refs/heads/ft/accordion-panel
+ export RH_BRANCH=ft
+ RH_BRANCH=ft

Fix branch names like ft/foo or fix/bar
@welcome
Copy link

welcome bot commented Jul 27, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073 blink1073 added the bug Something isn't working label Jul 27, 2021
@blink1073 blink1073 added this to the 0.3 milestone Jul 27, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #89 (dacd923) into master (84235d3) will decrease coverage by 2.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   87.83%   85.27%   -2.56%     
==========================================
  Files          15       16       +1     
  Lines        1759     1915     +156     
  Branches      213      241      +28     
==========================================
+ Hits         1545     1633      +88     
- Misses        134      191      +57     
- Partials       80       91      +11     
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/lib.py 74.28% <54.54%> (-0.43%) ⬇️
jupyter_releaser/util.py 69.87% <55.55%> (-12.32%) ⬇️
jupyter_releaser/tee.py 82.05% <82.05%> (ø)
jupyter_releaser/tests/test_cli.py 96.54% <82.75%> (-1.11%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.59% <100.00%> (+0.21%) ⬆️
jupyter_releaser/tests/test_functions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f29a78...dacd923. Read the comment docs.

@blink1073 blink1073 merged commit 675950d into jupyter-server:master Jul 27, 2021
@welcome
Copy link

welcome bot commented Jul 27, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval deleted the patch-1 branch July 27, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants