-
Notifications
You must be signed in to change notification settings - Fork 72
Add silent option #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fcollonval
merged 28 commits into
jupyter-server:main
from
fcollonval:enh/allow-silent-release
Nov 20, 2023
Merged
Add silent option #526
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
49f7071
Add silent option
fcollonval 91bd9c4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 14323dd
Add action and workflow to remove changelog silent entry
fcollonval 70c9cd0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6f7b9fe
Make the CI happier
fcollonval 9437da6
Add unit test for remove placeholder
fcollonval 5b0acdc
Fix typing
fcollonval 7531de1
TO REMOVE point to the current branch
fcollonval e8c9d5d
Fix logic to silent the entry in the changelog only when releasing
fcollonval 07e8dcd
Don't get the changelog for silent GH release in populate release
fcollonval b6b9d60
Debug populate-release
fcollonval 6dc07a2
Don't request metadata uselessly
fcollonval 351b40e
Ignore release missing known tagged released
fcollonval bc95ea1
Fix removing placeholder in changelong
fcollonval e8767fb
Remove debug log
fcollonval 0ad0f61
Revert "TO REMOVE point to the current branch"
fcollonval b56dfdc
Add documentation
fcollonval b3e3c0b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 18471a4
Don't print the changelog in the job log if the release is silent
fcollonval 63c70b0
Merge branch 'main' into enh/allow-silent-release
fcollonval 010b558
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1edfbed
Fix mypy errors
fcollonval 32126aa
Add ruff exception
fcollonval 2c63b7a
[skip ci] Comment new flag silent
fcollonval cd0154c
[skip ci] Comment new flag in example
fcollonval 2642722
Merge branch 'main' into enh/allow-silent-release
blink1073 c38ab98
Merge branch 'main' into enh/allow-silent-release
fcollonval 438c428
Fix doc
fcollonval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| name: "Publish Changelog" | ||
| description: "Remove silent placeholder entries in the changelog file." | ||
| inputs: | ||
| token: | ||
| description: "GitHub access token" | ||
| required: true | ||
| target: | ||
| description: "The owner/repo GitHub target" | ||
| required: true | ||
| branch: | ||
| description: "The branch to target" | ||
| required: false | ||
| dry_run: | ||
| description: "If set, do not make a PR" | ||
| default: "false" | ||
| required: false | ||
| outputs: | ||
| pr_url: | ||
| description: "The html URL of the draft GitHub release" | ||
| value: ${{ steps.publish-changelog.outputs.pr_url }} | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: install-releaser | ||
| shell: bash -eux {0} | ||
| run: | | ||
| # Install Jupyter Releaser from git unless we are testing Releaser itself | ||
| if ! command -v jupyter-releaser &> /dev/null | ||
| then | ||
| pip install -q git+https://github.com/jupyter-server/jupyter_releaser.git@v2 | ||
| fi | ||
|
|
||
| - id: publish-changelog | ||
| shell: bash -eux {0} | ||
| run: | | ||
| export GITHUB_ACCESS_TOKEN=${{ inputs.token }} | ||
| export GITHUB_ACTOR=${{ github.triggering_actor }} | ||
| export RH_REPOSITORY=${{ inputs.target }} | ||
| if [ ! -z ${{ inputs.branch }} ]; then | ||
| export RH_BRANCH=${{ inputs.branch }} | ||
| fi | ||
| export RH_DRY_RUN=${{ inputs.dry_run }} | ||
|
|
||
| python -m jupyter_releaser.actions.publish_changelog | ||
|
|
||
| - shell: bash -eux {0} | ||
| run: | | ||
| echo "## Next Step" >> $GITHUB_STEP_SUMMARY | ||
| echo "Merge the changelog update PR: ${{ steps.publish-changelog.outputs.pr_url }}" >> $GITHUB_STEP_SUMMARY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: "Publish Changelog" | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| token: | ||
| description: "GitHub access token" | ||
| required: true | ||
| target: | ||
| description: "The owner/repo GitHub target" | ||
| required: true | ||
| branch: | ||
| description: "The branch to target" | ||
| required: false | ||
|
|
||
| jobs: | ||
| publish_changelog: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
| - name: Install Dependencies | ||
| shell: bash | ||
| run: | | ||
| pip install -e . | ||
| - name: Publish changelog | ||
| id: publish-changelog | ||
| uses: jupyter-server/jupyter_releaser/.github/actions/publish-changelog@v2 | ||
| with: | ||
| token: ${{ secrets.ADMIN_GITHUB_TOKEN }} | ||
| target: ${{ github.event.inputs.target }} | ||
| branch: ${{ github.event.inputs.branch }} | ||
|
|
||
| - name: "** Next Step **" | ||
| run: | | ||
| echo "Merge the changelog update PR: ${{ steps.publish-changelog.outputs.pr_url }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: "Publish Changelog" | ||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| workflow_dispatch: | ||
| inputs: | ||
| token: | ||
| description: "GitHub access token" | ||
| required: true | ||
| branch: | ||
| description: "The branch to target" | ||
| required: false | ||
|
|
||
| jobs: | ||
| publish_changelog: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
| - name: Publish changelog | ||
| id: publish-changelog | ||
| uses: jupyter-server/jupyter_releaser/.github/actions/publish-changelog@v2 | ||
| with: | ||
| token: ${{ secrets.ADMIN_GITHUB_TOKEN }} | ||
| branch: ${{ github.event.inputs.branch }} | ||
|
|
||
| - name: "** Next Step **" | ||
| run: | | ||
| echo "Merge the changelog update PR: ${{ steps.publish-changelog.outputs.pr_url }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| """Remove silent placeholder entries in the changelog.""" | ||
| # Copyright (c) Jupyter Development Team. | ||
| # Distributed under the terms of the Modified BSD License. | ||
| import os | ||
|
|
||
| from jupyter_releaser.actions.common import run_action, setup | ||
| from jupyter_releaser.util import CHECKOUT_NAME, get_default_branch | ||
|
|
||
| setup(False) | ||
|
|
||
| run_action("jupyter-releaser prep-git") | ||
|
|
||
| # Handle the branch. | ||
| if not os.environ.get("RH_BRANCH"): | ||
| cur_dir = os.getcwd() | ||
| os.chdir(CHECKOUT_NAME) | ||
| os.environ["RH_BRANCH"] = get_default_branch() or "" | ||
| os.chdir(cur_dir) | ||
|
|
||
| run_action("jupyter-releaser publish-changelog") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.