Skip to content

Add log when loading configuration #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Add log when loading configuration #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions jupyter_releaser/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,17 +449,26 @@ def read_config():

if JUPYTER_RELEASER_CONFIG.exists():
config = toml.loads(JUPYTER_RELEASER_CONFIG.read_text(encoding="utf-8"))
log(f"jupyter-releaser configuration loaded from {JUPYTER_RELEASER_CONFIG}.")

if not config and PYPROJECT.exists():
if PYPROJECT.exists():
data = toml.loads(PYPROJECT.read_text(encoding="utf-8"))
pyproject_config = data.get("tool", {}).get("jupyter-releaser")
if pyproject_config:
config = pyproject_config
if not config:
config = pyproject_config
log(f"jupyter-releaser configuration loaded from {PYPROJECT}.")
else:
log(f"Ignoring jupyter-releaser configuration from {PYPROJECT}.")

if not config and PACKAGE_JSON.exists():
if PACKAGE_JSON.exists():
data = json.loads(PACKAGE_JSON.read_text(encoding="utf-8"))
if "jupyter-releaser" in data:
config = data["jupyter-releaser"]
if not config:
config = data["jupyter-releaser"]
log(f"jupyter-releaser configuration loaded from {PACKAGE_JSON}.")
else:
log(f"Ignoring jupyter-releaser configuration from {PACKAGE_JSON}.")

config = config or {}
validator = Validator(SCHEMA)
Expand Down