Skip to content

Do no install the package by default #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Do no install the package by default #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dcd8da
do no install the package by default
blink1073 Oct 17, 2022
2c70626
lint
blink1073 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions jupyter_releaser/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
from subprocess import CalledProcessError

import mdformat
import toml
from packaging.version import parse as parse_version
from pkginfo import SDist, Wheel

Expand Down Expand Up @@ -471,25 +470,6 @@ def prep_git(ref, branch, repo, auth, username, url):
except Exception:
util.run(f"git switch -c {branch}")

# Install the package
# install python package in editable mode with dev and test deps
if util.PYPROJECT.exists():
# check the package can be installed first
text = util.PYPROJECT.read_text(encoding="utf-8")
data = toml.loads(text)
if data.get("build-system"):
util.run('pip install -q -e ".[dev,test]"')

# prefer yarn if yarn lock exists
elif util.YARN_LOCK.exists():
if not shutil.which("yarn"):
util.run("npm install -g yarn")
util.run("yarn")

# npm install otherwise
elif util.PACKAGE_JSON.exists():
util.run("npm install")

try:
has_git_config = util.run("git config user.email").strip()
except Exception:
Expand Down