Skip to content

Conversation

@blink1073
Copy link
Contributor

@blink1073 blink1073 commented Jul 11, 2022

For now we disallow the use of "next" or "patch" when dev versions are used, until we can implement a proper fix as part of #272

@blink1073 blink1073 added the bug Something isn't working label Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #347 (16e0d35) into main (b29955a) will decrease coverage by 0.55%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   84.26%   83.71%   -0.56%     
==========================================
  Files          19       19              
  Lines        2599     2566      -33     
  Branches      344      343       -1     
==========================================
- Hits         2190     2148      -42     
- Misses        290      300      +10     
+ Partials      119      118       -1     
Impacted Files Coverage Δ
jupyter_releaser/changelog.py 84.28% <0.00%> (-2.15%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 91.45% <100.00%> (-0.18%) ⬇️
jupyter_releaser/lib.py 82.51% <100.00%> (+0.40%) ⬆️
jupyter_releaser/tests/test_cli.py 99.05% <100.00%> (-0.01%) ⬇️
jupyter_releaser/tests/test_functions.py 99.06% <100.00%> (-0.05%) ⬇️
jupyter_releaser/util.py 68.97% <100.00%> (-3.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29955a...16e0d35. Read the comment docs.

@blink1073 blink1073 merged commit 9152394 into jupyter-server:main Jul 11, 2022
@blink1073 blink1073 deleted the revert-recent-changes branch July 11, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants